hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13863) FsDatasetImpl should log DiskOutOfSpaceException
Date Tue, 28 Aug 2018 23:40:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595737#comment-16595737
] 

Wei-Chiu Chuang commented on HDFS-13863:
----------------------------------------

Patch looks good. It would be even better if the code that throws DiskOutOfSpaceException
also reports the reserved space versus the requested space. Can be a separate improvement
jira.

> FsDatasetImpl should log DiskOutOfSpaceException
> ------------------------------------------------
>
>                 Key: HDFS-13863
>                 URL: https://issues.apache.org/jira/browse/HDFS-13863
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>    Affects Versions: 3.1.0, 2.9.1, 3.0.3
>            Reporter: Fei Hui
>            Assignee: Fei Hui
>            Priority: Major
>         Attachments: HDFS-13863.001.patch, HDFS-13863.002.patch, HDFS-13863.003.patch
>
>
> The code in function *createRbw* as follow
> {code:java}
>         try {
>           // First try to place the block on a transient volume.
>           ref = volumes.getNextTransientVolume(b.getNumBytes());
>           datanode.getMetrics().incrRamDiskBlocksWrite();
>         } catch (DiskOutOfSpaceException de) {
>           // Ignore the exception since we just fall back to persistent storage.
>         } finally {
>           if (ref == null) {
>             cacheManager.release(b.getNumBytes());
>           }
>         }
> {code}
> I think we should log the exception because it took me long time to resolve problems,
and maybe others face the same problems.
> When i test ram_disk, i found no data was written into randomdisk. I debug, deep into
the source code, and found that randomdisk size was less than reserved space. I think if message
was logged, i would resolve the problem quickly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message