hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Kumar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDDS-369) Remove the containers of a dead node from the container state map
Date Mon, 27 Aug 2018 19:14:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594120#comment-16594120
] 

Ajay Kumar edited comment on HDDS-369 at 8/27/18 7:13 PM:
----------------------------------------------------------

[~elek] Patch LGTM. Minor nit:
Change log statement to parametrized logging. i.e 
{code}LOG.info("Datanode " + datanodeDetails.getUuid()
	        + " is dead. Removing replications from the in-memory state.");

LOG.info("Datanode {} is dead. Removing replications from the in-memory state.", datanodeDetails.getUuid());{code}

{code}LOG.error("Can't remove container from containerStateMap " + container.getId(), e);

to
LOG.error("Can't remove container from containerStateMap {}", container.getId(), e);{code}

Also apart from updating replica info, shouldn't this handler also update information related
to storage (space left/used) for cluster? 


was (Author: ajayydv):
[~elek] Patch LGTM. Minor nit:
Change log statement to parametrized logging. i.e 
{code}LOG.info("Datanode " + datanodeDetails.getUuid()
	        + " is dead. Removing replications from the in-memory state.");{code}
to 
LOG.info("Datanode {} is dead. Removing replications from the in-memory state.", datanodeDetails.getUuid());

{code}LOG.error("Can't remove container from containerStateMap " + container.getId(), e);{code}
to
{code}LOG.error("Can't remove container from containerStateMap {}", container.getId(), e);{code}

Also apart from updating replica info, shouldn't this handler also update information related
to storage (space left/used) for cluster? 

> Remove the containers of a dead node from the container state map
> -----------------------------------------------------------------
>
>                 Key: HDDS-369
>                 URL: https://issues.apache.org/jira/browse/HDDS-369
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: SCM
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-369.001.patch, HDDS-369.002.patch
>
>
> In case of a node is dead we need to update the container replicas information of the
containerStateMap for all the containers from that specific node.
> With removing the replica information we can detect the under replicated state and start
the replication.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message