hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-351) Add chill mode state to SCM
Date Thu, 30 Aug 2018 13:08:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597427#comment-16597427
] 

Elek, Marton commented on HDDS-351:
-----------------------------------

Thanks Ajay of working this. Overall I like the approach but I have some uncertainty about
the details of the patch.


1. I don't understand why do we need a Map for exitRules if we use just the only one element
everywhere. I think one single variable should be enough. Or I would expect at least some
loops.
For example why don't we cleanup other exitRules just exitRules.get(CONT_EXIT_RULE).cleanup()?

2.  And why do we need the CONT_EXIT_RULE? Are the keys of exitRules used somewhere? (Maybe
I missed something...)

3. Until know we tried to follow a practice where all the event wiring are defined in StorageContainerManager.
The only one exception was the EventWatcher but we also discussed it with Lokesh that the
wiring logic could be moved out from the EventWatcher constructor. To be honest I have no
preference. The only thing what I would like to do is handle all the subscription logic with
the same way. Either wire everything in the SCM class or move all the eventPublisher subscription
logic to constructors. 

4. Would be great to write a unit test for ContainerChillModeRule. I am not sure, but IMHO
containerWithMinReplicas should be incremented only if the containerReplicaMap.get(c.getContainerID())
was empty.  berfore. A unit test would convince me...

5. Not clear why do you do containers.remove(c.getContainerID()); at SCMChillModeManager:L171

6. Why did you remove:  eventQueue.addHandler(SCMEvents.START_REPLICATION, replicationStatus);
from SCM?



> Add chill mode state to SCM
> ---------------------------
>
>                 Key: HDDS-351
>                 URL: https://issues.apache.org/jira/browse/HDDS-351
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-351.00.patch, HDDS-351.01.patch, HDDS-351.02.patch, HDDS-351.03.patch
>
>
> Add chill mode state to SCM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message