hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13784) Metrics sampling period is milliseconds instead of seconds。
Date Thu, 16 Aug 2018 07:39:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582086#comment-16582086

Elek, Marton commented on HDFS-13784:

Thanks the patch [~candychencan].

Could you please add more description to explain the change?

For me the current code seems to be ok. The config parsing part is this:

     int sinkPeriod = conf.getInt(PERIOD_KEY, PERIOD_DEFAULT);
      // Support configuring periodMillis for testing.
      long sinkPeriodMillis =
          conf.getLong(PERIOD_MILLIS_KEY, sinkPeriod * 1000);

So the period key defines the period in second. After the parsing the final value is stored
in ms:

    period = confPeriodMillis > 0 ? confPeriodMillis
        : config.getLong(PERIOD_MILLIS_KEY, periodSec * 1000);

But it's just an internal representation and independent from the config keys.

Did I miss something?

> Metrics sampling period is milliseconds instead of seconds。
> -----------------------------------------------------------
>                 Key: HDFS-13784
>                 URL: https://issues.apache.org/jira/browse/HDFS-13784
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: chencan
>            Priority: Minor
>         Attachments: HDFS-13784.patch
> Metrics sampling period is milliseconds instead of seconds,this patch modify the related
configuration file.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message