hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13782) ObserverReadProxyProvider should work with IPFailoverProxyProvider
Date Fri, 24 Aug 2018 16:31:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591872#comment-16591872
] 

Erik Krogen commented on HDFS-13782:
------------------------------------

Besides rebasing on top of HDFS-13848 once it is committed, this looks fine to me overall.
I think the delegation approach instead of inheritance definitely makes sense. Though instantiating
the underlying proxy provider in the short-form constructor makes sense here, for HDFS-13779,
it would actually be better if it was instantiated later (to have more control over the factory).
I was thinking of passing in the class, rather than an instance, and creating it via reflection.
I am fine with just making this change as part of HDFS-13779 if you'd prefer not to do it
here.

Only other thing is, why have {{ObserverReadProxyProvider}} be tied to {{ConfiguredFailoverProxyProvider}}
instead of your original proposal with separate classes like {{ObserverReadProxyProviderWithConfiguredFailover}}
and {{ObserverReadProxyProviderWithIPFailover}}? Or, alternatively, just {{ObserverReadProxyProvider}},
but add a new config like {{dfs.client.failover.proxy-provider.observer-read.active-proxy-provider}}
to specify the underlying class?

> ObserverReadProxyProvider should work with IPFailoverProxyProvider
> ------------------------------------------------------------------
>
>                 Key: HDFS-13782
>                 URL: https://issues.apache.org/jira/browse/HDFS-13782
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Major
>         Attachments: HDFS-13782-HDFS-12943.001.patch
>
>
> Currently {{ObserverReadProxyProvider}} is based on {{ConfiguredFailoverProxyProvider}}.
We should also be able perform SBN reads in case of {{IPFailoverProxyProvider}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message