hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-13776) RBF: Add Storage policies related ClientProtocol APIs
Date Fri, 03 Aug 2018 17:33:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568506#comment-16568506
] 

Íñigo Goiri edited comment on HDFS-13776 at 8/3/18 5:32 PM:
------------------------------------------------------------

Thanks [~dibyendu_hadoop] for  [^HDFS-13776-000.patch].
A couple comments:
* Can we move the {{getLocationsForPath()}} chunks inside the {{RouterStoragePolicy}} (the
erasure coding module does that).
* Fix the javac warning by using assertArrayEquals or so.
* Can we add a javadoc to the new class?
* Minor styles nits:
** Remove the extra space in {{private  final RouterStoragePolicy storagePolicy;}}.
** Add an extra line in RouterRpcServer#211 to keep the double space separation.

The tests look good, have you tested this in a cluster or so?


was (Author: elgoiri):
Thanks [~dibyendu_hadoop] for  [^HDFS-13776-000.patch].
A couple comments:
* Can we move the {{getLocationsForPath()}} chunks inside the {{RouterStoragePolicy}} (the
erasure coding module does that).
* Fix the javac warning by using assertArrayEquals or so.
* Minor styles nits:
** Remove the extra space in {{private  final RouterStoragePolicy storagePolicy;}}.
** Add an extra line in RouterRpcServer#211 to keep the double space separation.

The tests look good, have you tested this in a cluster or so?

> RBF: Add Storage policies related ClientProtocol APIs
> -----------------------------------------------------
>
>                 Key: HDFS-13776
>                 URL: https://issues.apache.org/jira/browse/HDFS-13776
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Dibyendu Karmakar
>            Assignee: Dibyendu Karmakar
>            Priority: Major
>         Attachments: HDFS-13776-000.patch
>
>
> Currently unsetStoragePolicy and getStoragePolicy are not implemented in RouterRpcServer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message