hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mukul Kumar Singh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-280) Support ozone dist-start-stitching on openbsd/osx
Date Wed, 29 Aug 2018 19:27:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596761#comment-16596761
] 

Mukul Kumar Singh commented on HDDS-280:
----------------------------------------

Thanks for working on this [~elek]. The patch looks good to me as well.

+1 for the v3 patch, there is a minor nitpick in acceptance-test/pom.xml:47, the indentation
is off by 1.
I will handle this during commit.

> Support ozone dist-start-stitching on openbsd/osx
> -------------------------------------------------
>
>                 Key: HDDS-280
>                 URL: https://issues.apache.org/jira/browse/HDDS-280
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-280.001.patch, HDDS-280.002.patch, HDDS-280.003.patch
>
>
> {quote}Ozone is creating a symlink during the dist process.
> Using the "ozone" directory as a destination name all the docker-based acceptance tests
and docker-compose files are more simple as they don't need to have the version information
in the path.
> But to keep the version specific folder name in the tar file we create a symbolic link
during the tar creation. With the symbolic link and the '–dereference' tar argument we can
create the tar file which includes a versioned directory (ozone-0.2.1) but we can use the
a dist directory without the version in the name (hadoop-dist/target/ozone).
> {quote}
> This is the description of the current dev-support/bin/ozone-dist-tar-stitching. [~aw]
in a comment for HDDS-276 pointed to the problem that some bsd variants don't support the
dereference command line options of the ln command.
> The main reason to use this approach is to get a simplified destination name without
the version (hadoop-dist/target/ozone instead of hadoop-dist/target/ozone-0.2.1). It simplifies
the docker-compose based environments and acceptance tests, therefore I prefer to keep the
simplified destination name.
> The issue is the tar file creation, if and only if we need the version number in the
name of the root directory inside of the tar.
> Possible solutions:
>  # Use cp target/ozone target/ozone-0.2.1 + tar. It's simple but more slow and requires
more space.
>  # Do the tar distribution from docker all the time in case of 'dereference' is not supported.
Not very convenient
>  # Accept that tar will contain ozone directory and not ozone-0.2.1. This is the more
simple and can be improved with an additional VERSION file in the root of the distribution.
>  # (+1) Use hadoop-dist/target/ozone-0.2.1 instead of hadoop-dist/target/ozone. This
is more complex for the docker based testing as we need the explicit names in the compose
files (volume: ../../../hadoop-dist/target/ozone-0.2.1). The structure is more complex with
using version in the directory name.
> Please comment your preference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message