hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lokesh Jain (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-265) Move numPendingDeletionBlocks and deleteTransactionId from ContainerData to KeyValueContainerData
Date Wed, 08 Aug 2018 11:08:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573025#comment-16573025
] 

Lokesh Jain commented on HDDS-265:
----------------------------------

[~GeLiXin] Thanks for working on this! The patch looks good to me. Please find my comments
below.
 # ContainerDeletionChoosingPolicy:55 - Redundant change.
 # TopNOrderedContainerDeletionChoosingPolicy:46-54 - Can be replaced with a lambda expression.
 # We can add a default implementation for isValidContainerType in ContainerDeletionChoosingPolicy.
 # We can create a new class KeyValueContainerReport which extends ContainerReport. We can
define deleteTransactionId field in KeyValueContainerReport.

> Move numPendingDeletionBlocks and deleteTransactionId from ContainerData to KeyValueContainerData
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDDS-265
>                 URL: https://issues.apache.org/jira/browse/HDDS-265
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>    Affects Versions: 0.2.1
>            Reporter: Hanisha Koneru
>            Assignee: LiXin Ge
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-265.000.patch, HDDS-265.001.patch
>
>
> "numPendingDeletionBlocks" and "deleteTransactionId" fields are specific to KeyValueContainers.
As such they should be moved to KeyValueContainerData from ContainerData.
> ContainerReport should also be refactored to take in this change. 
> Please refer to [~ljain]'s comment in HDDS-250.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message