From hdfs-issues-return-227830-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Jul 30 16:52:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4A392180674 for ; Mon, 30 Jul 2018 16:52:04 +0200 (CEST) Received: (qmail 42830 invoked by uid 500); 30 Jul 2018 14:52:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 42819 invoked by uid 99); 30 Jul 2018 14:52:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jul 2018 14:52:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C5C7BCC465 for ; Mon, 30 Jul 2018 14:52:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id NEYI5DVdDrPJ for ; Mon, 30 Jul 2018 14:52:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7F76C5F3EF for ; Mon, 30 Jul 2018 14:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A8094E25AA for ; Mon, 30 Jul 2018 14:52:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5D26427756 for ; Mon, 30 Jul 2018 14:52:00 +0000 (UTC) Date: Mon, 30 Jul 2018 14:52:00 +0000 (UTC) From: "Nanda kumar (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDDS-245) Handle ContainerReports in the SCM MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDDS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561988#comment-16561988 ] Nanda kumar commented on HDDS-245: ---------------------------------- Overall the patch looks good. {quote}we can commit this patch and go rewrite containerMapping.processContainerReports function later. {quote} Created HDDS-303 for this *ContainerReportHandler.java* {{replicationStatus.isReplicationEnabled()}} is checked twice, 128 & 135, one can be removed. *ReportResult.java* Line:60, 61: {{new HashSet<>()}} can be replaced with {{Collections.emptySet()}} > Handle ContainerReports in the SCM > ---------------------------------- > > Key: HDDS-245 > URL: https://issues.apache.org/jira/browse/HDDS-245 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: SCM > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-245.001.patch, HDDS-245.002.patch, HDDS-245.003.patch, HDDS-245.004.patch > > > HDDS-242 provides a new class ContainerReportHandler which could handle the ContainerReports from the SCMHeartbeatDispatchere. > HDDS-228 introduces a new map to store the container -> datanode[] mapping > HDDS-199 implements the ReplicationManager which could send commands to the datanodes to copy the datanode. > To wire all these components, we need to put implementation to the ContainerReportHandler (created in HDDS-242). > The ContainerReportHandler should process the new ContainerReportForDatanode events, update the containerStateMap and node2ContainerMap and calculate the missing/duplicate containers and send the ReplicateCommand to the ReplicateManager. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org