From hdfs-issues-return-227886-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jul 31 00:48:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 12AEA18067B for ; Tue, 31 Jul 2018 00:48:04 +0200 (CEST) Received: (qmail 22817 invoked by uid 500); 30 Jul 2018 22:48:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 22803 invoked by uid 99); 30 Jul 2018 22:48:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jul 2018 22:48:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 804C21A336C for ; Mon, 30 Jul 2018 22:48:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id pwv9BNd1j-Im for ; Mon, 30 Jul 2018 22:48:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1887C5F54E for ; Mon, 30 Jul 2018 22:48:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 01A24E2621 for ; Mon, 30 Jul 2018 22:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5784427763 for ; Mon, 30 Jul 2018 22:48:00 +0000 (UTC) Date: Mon, 30 Jul 2018 22:48:00 +0000 (UTC) From: "Erik Krogen (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13688) Introduce msync API call MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562631#comment-16562631 ] Erik Krogen commented on HDFS-13688: ------------------------------------ Hey [~vagarychen], I think separating out into client- and server-side makes sense. However, this patch which claims to be only client-side is still making changes to server-side classes like {{o.a.h.ipc.Server}}, {{GlobalStateIdContext}}. Would it be better to have this as a part of the server-side change? That being said, in {{GlobalStateIdContext}}, should we be using {{getCorrectLastAppliedOrWrittenTxId}} rather than {{getLastAppliedOrWrittenTxId}}, which gets the ID without a lock? This could result in an older txn ID value being returned. I think we need to take the lock here. One minor nit, the Javadoc for {{DFSClient#msync()}} should have an empty line before the {{@throws}} > Introduce msync API call > ------------------------ > > Key: HDFS-13688 > URL: https://issues.apache.org/jira/browse/HDFS-13688 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Chen Liang > Assignee: Chen Liang > Priority: Major > Attachments: HDFS-13688-HDFS-12943.001.patch, HDFS-13688-HDFS-12943.002.patch, HDFS-13688-HDFS-12943.002.patch, HDFS-13688-HDFS-12943.003.patch, HDFS-13688-HDFS-12943.004.patch, HDFS-13688-HDFS-12943.WIP.002.patch, HDFS-13688-HDFS-12943.WIP.patch > > > As mentioned in the design doc in HDFS-12943, to ensure consistent read, we need to introduce an RPC call {{msync}}. Specifically, client can issue a msync call to Observer node along with a transactionID. The msync will only return when the Observer's transactionID has caught up to the given ID. This JIRA is to add this API. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org