From hdfs-issues-return-226562-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jul 17 22:36:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2A9A5180600 for ; Tue, 17 Jul 2018 22:36:04 +0200 (CEST) Received: (qmail 85186 invoked by uid 500); 17 Jul 2018 20:36:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 85175 invoked by uid 99); 17 Jul 2018 20:36:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jul 2018 20:36:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B8BD3C0FA6 for ; Tue, 17 Jul 2018 20:36:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id r4W1yjpfFkwL for ; Tue, 17 Jul 2018 20:36:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 512B05F491 for ; Tue, 17 Jul 2018 20:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7FE5FE0E28 for ; Tue, 17 Jul 2018 20:36:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 31FDE23F9A for ; Tue, 17 Jul 2018 20:36:00 +0000 (UTC) Date: Tue, 17 Jul 2018 20:36:00 +0000 (UTC) From: "Xiao Chen (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13622) dfs mkdir should not report the directory which to be created MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547079#comment-16547079 ] Xiao Chen commented on HDFS-13622: ---------------------------------- Thanks [~kgyrtkirk] for creating the jira and [~shwetayakkali] for working on it. Overall looks good. Review comments: - I would move the comments into the {{if}} block for clarity - In the test, we should verify the path in the message is correct. Namely, no 'testChild' (so the test fails before the fix, and passes after) - Need space around brackets for the line {{if(!createParents){}} > dfs mkdir should not report the directory which to be created > ------------------------------------------------------------- > > Key: HDFS-13622 > URL: https://issues.apache.org/jira/browse/HDFS-13622 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Zoltan Haindrich > Assignee: Shweta > Priority: Major > Attachments: HDFS-13622.02.patch > > > this is a bit misleading: > {code} > $ hdfs dfs -mkdir /nonexistent/newdir > mkdir: `/nonexistent/newdir': No such file or directory > {code} > I think this command should fail because "nonexistent" doesn't exists... > the correct would be: > {code} > $ hdfs dfs -mkdir /nonexistent/newdir > mkdir: `/nonexistent': No such file or directory > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org