From hdfs-issues-return-227001-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Jul 20 22:47:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 62F7418077B for ; Fri, 20 Jul 2018 22:47:08 +0200 (CEST) Received: (qmail 69752 invoked by uid 500); 20 Jul 2018 20:47:07 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 69598 invoked by uid 99); 20 Jul 2018 20:47:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jul 2018 20:47:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E4BBA180A03 for ; Fri, 20 Jul 2018 20:47:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 0OsdtUfE9LES for ; Fri, 20 Jul 2018 20:47:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1FB085F536 for ; Fri, 20 Jul 2018 20:47:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CBB0AE25D6 for ; Fri, 20 Jul 2018 20:47:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 17B632743D for ; Fri, 20 Jul 2018 20:47:02 +0000 (UTC) Date: Fri, 20 Jul 2018 20:47:02 +0000 (UTC) From: "Wei-Chiu Chuang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-12886) Ignore minReplication for block recovery MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551264#comment-16551264 ] Wei-Chiu Chuang commented on HDFS-12886: ---------------------------------------- I stand corrected: the data corruption bug caused by concurrent recoverLease() and close() is *NOT* fixed by HDFS-12886. In fact, it is accidentally fixed by HDFS-8909. Basically, HDFS-8909 added an assertion that if a block recovery command is being asked, it checks if the block is actually under recovery. So after HDFS-8909, the recoverLease() call is ignored. However, note that under a more delicate condition, concurrent recoverLease() + close() could still corrupt block. Ignoring block recovery if the block is not under recovery is not the ultimate solution. Instead, the close() should be ignored/rejected when block is being recovered. > Ignore minReplication for block recovery > ---------------------------------------- > > Key: HDFS-12886 > URL: https://issues.apache.org/jira/browse/HDFS-12886 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs, namenode > Reporter: Lukas Majercak > Assignee: Lukas Majercak > Priority: Major > Fix For: 3.1.0, 2.10.0, 2.9.1, 3.0.3 > > Attachments: HDFS-12886.001.patch, HDFS-12886.002.patch, HDFS-12886_branch-2.000.patch > > > Ignore minReplication for blocks that went through recovery, and allow NN to complete them and replicate. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org