hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-256) Adding CommandStatusReport Handler
Date Thu, 19 Jul 2018 21:23:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549883#comment-16549883
] 

Xiaoyu Yao commented on HDDS-256:
---------------------------------

Thanks [~ajayydv] for working on this. Patch v2 looks good to me, I just have few minor comments:

 

 

CommandStatusReportHandler.java

Line 106/115: comments need to be updated.

 

 

TestCommandStatusReportHandler.java

Missing ASF license header.

Line 37: storagePath is never used and can be removed.

>  Adding CommandStatusReport Handler
> -----------------------------------
>
>                 Key: HDDS-256
>                 URL: https://issues.apache.org/jira/browse/HDDS-256
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>    Affects Versions: 0.2.1
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-256.00.patch, HDDS-256.01.patch
>
>
> CommandStatusReportPublisher publishes status of SCM commands via Heartbeats. This is
handler for those command status reports responsible for sending command status to corresponding
watchers. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message