hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-13653) Make dfs.client.failover.random.order a per nameservice configuration
Date Tue, 05 Jun 2018 23:10:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502632#comment-16502632
] 

Íñigo Goiri edited comment on HDFS-13653 at 6/5/18 11:09 PM:
-------------------------------------------------------------

Thanks [~ekanth], the unit test is exactly what I was talking about.
A couple comments:
* It will complain about the missing license.
* We probably should check nnXCount.get() > 0 in the random case.
* It could use some refactoring, currently it has 3 mocks that are pretty much the same in
a couple test cases.
* numIterations could be a constant.


was (Author: elgoiri):
Thanks [~ekanth], the unit test is exactly what I was talking about.
A couple comments:
* It will complain about the missing license.
* We probably should check nnXCount.get() > 0 in the random case.
* It could use some refactoring, currently it has 3 mocks that are pretty much the same in
a couple test cases.

> Make dfs.client.failover.random.order a per nameservice configuration
> ---------------------------------------------------------------------
>
>                 Key: HDFS-13653
>                 URL: https://issues.apache.org/jira/browse/HDFS-13653
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: federation
>            Reporter: Ekanth Sethuramalingam
>            Assignee: Ekanth Sethuramalingam
>            Priority: Major
>         Attachments: HDFS-13653.001.patch, HDFS-13653.002.patch, HDFS-13653.003.patch,
HDFS-13653.004.patch, HDFS-13653.005.patch
>
>
> Currently the dfs.client.failover.random.order is applied globally. If we have a combination
of router and non-router nameservice, the random order should ideally be enabled only for
the router based nameservice. This Jira is to make this configuration per-nameservice so
that this can be configured independently for each nameservice. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message