hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-13608) [Edit Tail Fast Path Pt 2] Add ability for JournalNode to serve edits via RPC
Date Thu, 07 Jun 2018 16:24:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504880#comment-16504880
] 

Erik Krogen edited comment on HDFS-13608 at 6/7/18 4:23 PM:
------------------------------------------------------------

Thanks [~vagarychen]!

# Sure, making it required seems reasonable. Done.
# Agree that more documentation in the Javadoc would be good. Judging by the way the Javadoc
in {{QJournalProtocol}} abruptly cuts off, I think I actually got partway through this and
forgot to finish it... I fleshed out this Javadoc more in general and made sure to include
mention of the requirement of enabling in-progress edit tailing.
# I agree that there could be multiple concurrent calls to {{getJournaledEdits}}, and that
these could occur concurrently with the addition of new edits via {{journal}}. {{JournaledEditsCache}}
has the necessary synchronization to ensure that this isn't a problem, but let me know if
you see any issues.

Attaching v002 patch incorporating the above changes.


was (Author: xkrogen):
Thanks [~vagarychen]!

# Sure, making it required seems reasonable. Done.
# Agree that more documentation in the Javadoc would be good. Judging by the way the Javadoc
in {{QJournalProtocol}} abruptly cuts off, I think I actually got partway through this and
forgot to finish it... I fleshed out this Javadoc more in general and made sure to include
mention of the requirement of enabling in-progress edit tailing.
# I agree that there could be multiple concurrent calls to {{getJournaledEdits}}, and that
these could occur concurrently with the addition of new edits via {{journal}}. {{JournaledEditsCache}}
has the necessary synchronization to ensure that this isn't a problem, but let me know if
you see any issues.

Attaching v001 patch incorporating the above changes.

> [Edit Tail Fast Path Pt 2] Add ability for JournalNode to serve edits via RPC
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-13608
>                 URL: https://issues.apache.org/jira/browse/HDFS-13608
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Major
>         Attachments: HDFS-13608-HDFS-12943.000.patch, HDFS-13608-HDFS-12943.001.patch
>
>
> See HDFS-13150 for full design.
> This JIRA is to make the JournalNode-side changes necessary to support serving edits
via RPC. This includes interacting with the cache added in HDFS-13607.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message