hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Bota (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-13511) Provide specialized exception when block length cannot be obtained
Date Mon, 04 Jun 2018 18:34:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gabor Bota updated HDFS-13511:
------------------------------
    Attachment: HDFS-13511.003.patch

> Provide specialized exception when block length cannot be obtained
> ------------------------------------------------------------------
>
>                 Key: HDFS-13511
>                 URL: https://issues.apache.org/jira/browse/HDFS-13511
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Gabor Bota
>            Priority: Major
>         Attachments: HDFS-13511.001.patch, HDFS-13511.002.patch, HDFS-13511.003.patch
>
>
> In downstream project, I saw the following code:
> {code}
>         FSDataInputStream inputStream = hdfs.open(new Path(path));
> ...
>         if (options.getRecoverFailedOpen() && dfs != null && e.getMessage().toLowerCase()
>             .startsWith("cannot obtain block length for")) {
> {code}
> The above tightly depends on the following in DFSInputStream#readBlockLength
> {code}
>     throw new IOException("Cannot obtain block length for " + locatedblock);
> {code}
> The check based on string matching is brittle in production deployment.
> After discussing with [~stevel@apache.org], better approach is to introduce specialized
IOException, e.g. CannotObtainBlockLengthException so that downstream project doesn't have
to rely on string matching.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message