hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12571) Ozone: remove spaces from the beginning of the hdfs script
Date Sat, 09 Jun 2018 22:35:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507175#comment-16507175
] 

Elek, Marton commented on HDFS-12571:
-------------------------------------

Hi [~kmarton]

The root cause of the original problem was a space before the bash hashbang. I checked it
on the source tree of 3.0.1 tag and in the binary distribution of the 3.1.0 hadoop and everything
looks fine

{code:java}
find -type f -executable | xargs -n1 head -n1 | less | grep bash | sort | uniq
{code}

(yes, I know that this check is dummy but was effective).

On the other hand in the 3.1.0 binary distribution there are only 165 lines:

{code}
cat ./libexec/hadoop-config.sh | wc                                                  
    165     717    5457
{code}

It seems you have at least 273 lines:

{code}
/hadoop/hadoop-3.1.0/bin/../libexec/hadoop-config.sh: line 273: hadoop_generic_java_subcmd_handler:
command not found
{code}

Could you please share what kind of hadoop distribution do you have? Is it an binary distribution
of the apache release, custom built from source or any other distribution?

Also: Could you please check your hashbangs with the previous command?

IMHO It could be a different problem as  this space problem was introduced only on the HDFS
branch which was merged to trunk. Could be a different (but may be similar) problem on 3.0.1
/ 3.1.0.

> Ozone: remove spaces from the beginning of the hdfs script  
> ------------------------------------------------------------
>
>                 Key: HDFS-12571
>                 URL: https://issues.apache.org/jira/browse/HDFS-12571
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Critical
>              Labels: ozoneMerge
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12571-HDFS-7240.001.patch
>
>
> It seems that during one of the previous merge some unnecessary spaces has been added
to the hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs file.
> After a dist build I can not start server with the hdfs command:
> {code}
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-functions.sh: line 398: syntax error
near unexpected token `<'
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-functions.sh: line 398: `  done <
<(for text in "${input[@]}"; do'
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-config.sh: line 70: hadoop_deprecate_envvar:
command not found
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-config.sh: line 87: hadoop_bootstrap:
command not found
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-config.sh: line 104: hadoop_parse_args:
command not found
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-config.sh: line 105: shift: : numeric
argument required
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-config.sh: line 110: hadoop_find_confdir:
command not found
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-config.sh: line 111: hadoop_exec_hadoopenv:
command not found
> /tmp/hadoop-3.1.0-SNAPSHOT/bin/../libexec/hadoop-config.sh: line 112: hadoop_import_shellprofiles:
command not found
> {code}
> See the space at here:
> https://github.com/apache/hadoop/blob/d0bd0f623338dbb558d0dee5e747001d825d92c5/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
> Or see the latest version at:
> https://github.com/apache/hadoop/blob/HDFS-7240/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
> To be honest I don't understand how it could work for others, as it seems to be an older
change. Maybe some git magic removed it on OSX (I use linux). Anyway I upload a patch to fix
it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message