hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-13598) Reduce unnecessary byte-to-string transform operation in INodesInPath#toString
Date Thu, 24 May 2018 03:00:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yiqun Lin updated HDFS-13598:
-----------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 3.2.0
           Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks [~gabor.bota] for the contribution.

> Reduce unnecessary byte-to-string transform operation in INodesInPath#toString
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-13598
>                 URL: https://issues.apache.org/jira/browse/HDFS-13598
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.1.0
>            Reporter: Yiqun Lin
>            Assignee: Gabor Bota
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: HDFS-13598.001.patch
>
>
> Every time we invoke {{INodesInPath#toString()}}, we will trigger one time byte-to-string
transform operation.
> {code:java}
> private String toString(boolean vaildateObject) {
>     if (vaildateObject) {
>       validate();
>     }
>     final StringBuilder b = new StringBuilder(getClass().getSimpleName())
>         .append(": path = ").append(DFSUtil.byteArray2PathString(path))
>         .append("\n  inodes = ");
>         ...
> }
> {code}
> But actually we only need to do at most one time. In {{INodesInPath}}, it has defined
one String type variable named {{pathname}} for storing the path string value. Here we can
use {{getPath()}} to replace {{DFSUtil.byteArray2PathString(path)}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message