hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDDS-82) Merge ContainerData and ContainerStatus classes
Date Mon, 21 May 2018 18:31:00 GMT

    [ https://issues.apache.org/jira/browse/HDDS-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482872#comment-16482872
] 

Xiaoyu Yao commented on HDDS-82:
--------------------------------

Thanks [~bharatviswa] for working on this. The patch v2 looks good to me overall. I just have
few minor comments:

 

ContainerManagerImpl.java

Line 245/286: If we change here to allow putting null into containerMap, we will need to add
null check in many places when containerMap.get() is called such as Line 835/930/941,etc.
to avoid NPE. I would suggest we follow the existing pattern by putting a "new ContainerData(containerID,
conf)" with an INVALID state;

 

Line 462: here we need to check the containerData.state == INVALID

> Merge ContainerData and ContainerStatus classes
> -----------------------------------------------
>
>                 Key: HDDS-82
>                 URL: https://issues.apache.org/jira/browse/HDDS-82
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-82.001.patch, HDDS-82.002.patch
>
>
> According to refactoring of containerIO, ContainerData has common fields for different
kinds of containerTypes, and each Container will extend ConatinerData to add its fields. So,
for this merging ContainerStatus fields to ConatinerData.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message