hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12981) HDFS renameSnapshot to Itself for Non Existent snapshot should throw error
Date Fri, 04 May 2018 17:52:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464197#comment-16464197
] 

Xiao Chen commented on HDFS-12981:
----------------------------------

Thanks [~saileshpatel] for creating the jira with good details, and [~knanasi] for working
on this!

The patch looks pretty good to me. Could you please fix the last checkstyles reported by jenkins?
We don't change existing stuff unnecessarily, but try not to introduce new ones.

There is also a unnecessary space change after {{TestSnapshotRename#testRenameToExistingSnapshot}},
let's drop that too.

> HDFS  renameSnapshot to Itself for Non Existent snapshot should throw error
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-12981
>                 URL: https://issues.apache.org/jira/browse/HDFS-12981
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 2.6.0
>            Reporter: Sailesh Patel
>            Assignee: Kitti Nanasi
>            Priority: Minor
>         Attachments: HDFS-12981-branch-2.6.0.001.patch, HDFS-12981-branch-2.6.0.002.patch,
HDFS-12981.001.patch, HDFS-12981.002.patch, HDFS-12981.003.patch
>
>
> When trying to rename a non-existent HDFS  snapshot to ITSELF, there are no errors and
exits with a success code.
> The steps to reproduce this issue is:
> hdfs dfs -mkdir /tmp/dir1
> hdfs dfsadmin -allowSnapshot /tmp/dir1
> hdfs dfs 	-createSnapshot /tmp/dir1  snap1_dir
> Rename from non-existent to another_non-existent : errors and return code 1.  This is
correct.
>   hdfs dfs -renameSnapshot /tmp/dir1 nonexist another_nonexist  : 
>   echo $?
>    
>   renameSnapshot: The snapshot nonexist does not exist for directory /tmp/dir1
> Rename from non-existent to non-existent : no errors and return code 0  instead of Error
and return code 1.
>   hdfs dfs -renameSnapshot /tmp/dir1 nonexist nonexist  ;  echo $?
> Current behavior:   No error and return code 0.
> Expected behavior:  An error returned and return code 1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message