From hdfs-issues-return-216861-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Apr 17 13:28:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DE08318076D for ; Tue, 17 Apr 2018 13:28:05 +0200 (CEST) Received: (qmail 81026 invoked by uid 500); 17 Apr 2018 11:28:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 81011 invoked by uid 99); 17 Apr 2018 11:28:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2018 11:28:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 68A46C00DA for ; Tue, 17 Apr 2018 11:28:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id XZ2bd28pVvbK for ; Tue, 17 Apr 2018 11:28:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 154025F126 for ; Tue, 17 Apr 2018 11:28:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BC458E031B for ; Tue, 17 Apr 2018 11:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6EDB1241C4 for ; Tue, 17 Apr 2018 11:28:00 +0000 (UTC) Date: Tue, 17 Apr 2018 11:28:00 +0000 (UTC) From: "genericqa (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13454) Ozone : Fix the test logic in TestKeySpaceManager#testDeleteKey MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13454?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1644= 0766#comment-16440766 ]=20 genericqa commented on HDFS-13454: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 42s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 1 new or modif= ied test files. {color} | || || || || {color:brown} HDFS-7240 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 29m 15s{color} | {color:green} HDFS-7240 passed {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 26s{= color} | {color:red} integration-test in HDFS-7240 failed. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 17s{color} | {color:green} HDFS-7240 passed {color} | | {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 18s{= color} | {color:red} integration-test in HDFS-7240 failed. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 12m 7s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m = 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoo= p-ozone/integration-test {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 0m 0s{color} | {color:green} HDFS-7240 passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 14s{= color} | {color:red} integration-test in HDFS-7240 failed. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 1= 1s{color} | {color:red} integration-test in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 11s{= color} | {color:red} integration-test in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 11s{co= lor} | {color:red} integration-test in the patch failed. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 10s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 12s{= color} | {color:red} integration-test in the patch failed. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 12m 50s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m = 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoo= p-ozone/integration-test {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 0m 0s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 15s{= color} | {color:red} integration-test in the patch failed. {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 14s{col= or} | {color:red} integration-test in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 2= 6s{color} | {color:red} The patch generated 5 ASF License warnings. {color}= | | {color:black}{color} | {color:black} {color} | {color:black} 58m 18s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:b78c9= 4f | | JIRA Issue | HDFS-13454 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1291938= 5/HDFS-13454-HDFS-7240.000.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsit= e unit shadedclient findbugs checkstyle | | uname | Linux d525fbc9cea9 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 = 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HDFS-7240 / 1e0507a | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_162 | | compile | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/artifa= ct/out/branch-compile-hadoop-ozone_integration-test.txt | | mvnsite | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/artifa= ct/out/branch-mvnsite-hadoop-ozone_integration-test.txt | | javadoc | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/artifa= ct/out/branch-javadoc-hadoop-ozone_integration-test.txt | | mvninstall | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/art= ifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt | | compile | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/artifa= ct/out/patch-compile-hadoop-ozone_integration-test.txt | | javac | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/artifact= /out/patch-compile-hadoop-ozone_integration-test.txt | | mvnsite | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/artifa= ct/out/patch-mvnsite-hadoop-ozone_integration-test.txt | | javadoc | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/artifa= ct/out/patch-javadoc-hadoop-ozone_integration-test.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/artifact/= out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/= testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HDFS-Build/23966/art= ifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 331 (vs. ulimit of 10000) | | modules | C: hadoop-ozone/integration-test U: hadoop-ozone/integration-te= st | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23966= /console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Ozone : Fix the test logic in TestKeySpaceManager#testDeleteKey > --------------------------------------------------------------- > > Key: HDFS-13454 > URL: https://issues.apache.org/jira/browse/HDFS-13454 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Reporter: Shashikant Banerjee > Assignee: Shashikant Banerjee > Priority: Major > Fix For: HDFS-7240 > > Attachments: HDFS-13454-HDFS-7240.000.patch > > > The test logic in=C2=A0TestKeySpaceManager#testDeleteKey seems to be wron= g. The test validates the keyArgs instead of blockId to make sure the key g= ets deleted from SCM. Also, after the first exception validation , the subs= equent statements in the junit never gets executed here. > {code:java} > keys.add(keyArgs.getResourceName()); > exception.expect(IOException.class); > exception.expectMessage("Specified block key does not exist"); > cluster.getStorageContainerManager().getBlockLocations(keys); > // Delete the key again to test deleting non-existing key. > // These will never get executed. > exception.expect(IOException.class); > exception.expectMessage("KEY_NOT_FOUND"); > storageHandler.deleteKey(keyArgs); > Assert.assertEquals(1 + numKeyDeleteFails, > ksmMetrics.getNumKeyDeletesFails());{code} > The test needs to be modified to address all these. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org