From hdfs-issues-return-216462-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Apr 12 22:22:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 35183180634 for ; Thu, 12 Apr 2018 22:22:03 +0200 (CEST) Received: (qmail 94866 invoked by uid 500); 12 Apr 2018 20:22:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 94854 invoked by uid 99); 12 Apr 2018 20:22:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 20:22:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BEB7E18000B for ; Thu, 12 Apr 2018 20:22:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id CTbObM6jlWsu for ; Thu, 12 Apr 2018 20:22:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DE1095F47D for ; Thu, 12 Apr 2018 20:22:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6FA8CE00A3 for ; Thu, 12 Apr 2018 20:22:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 30F66240C6 for ; Thu, 12 Apr 2018 20:22:00 +0000 (UTC) Date: Thu, 12 Apr 2018 20:22:00 +0000 (UTC) From: "Ajay Kumar (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13435) RBF: Fix wrong error loggings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13435?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1643= 6254#comment-16436254 ]=20 Ajay Kumar commented on HDFS-13435: ----------------------------------- [~linyiqun] [~elgoiri]=C2=A0Usually exception message is=C2=A0 not enough f= or people who are not very familier with code base. Stack trace goes long w= ay in debugging critical issues. That said we can skip stack trace for triv= ial errors but keep it otherwise.=C2=A0 > RBF: Fix wrong error loggings > ----------------------------- > > Key: HDFS-13435 > URL: https://issues.apache.org/jira/browse/HDFS-13435 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: 3.0.1 > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Priority: Major > Attachments: HDFS-13435.001.patch > > > There are many places that using {{Logger.error(String format, Object... = arguments)}} incorrectly. > A example: > {code:java} > LOG.error("Cannot remove {}", path, e); > {code} > The exception passed here is no meaning and won't be printed. Actually it= should be update to > {code:java} > LOG.error("Cannot remove {}: {}.", path, e.getMessage()); > {code} > or=20 > {code:java} > LOG.error("Cannot remove " + path, e)); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org