From hdfs-issues-return-216231-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Apr 11 14:50:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 55B5118067B for ; Wed, 11 Apr 2018 14:50:05 +0200 (CEST) Received: (qmail 95508 invoked by uid 500); 11 Apr 2018 12:50:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 95296 invoked by uid 99); 11 Apr 2018 12:50:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2018 12:50:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D1028C72CB for ; Wed, 11 Apr 2018 12:50:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id US1HTVFF6ZdB for ; Wed, 11 Apr 2018 12:50:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 99C1E5F5B2 for ; Wed, 11 Apr 2018 12:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BBB4DE0BD4 for ; Wed, 11 Apr 2018 12:50:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 38894241CB for ; Wed, 11 Apr 2018 12:50:00 +0000 (UTC) Date: Wed, 11 Apr 2018 12:50:00 +0000 (UTC) From: "BELUGA BEHR (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-13428) Remove LinkedList From StateStoreFileImpl.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13428?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HDFS-13428: ------------------------------- Status: Patch Available (was: Open) > Remove LinkedList From StateStoreFileImpl.java > ---------------------------------------------- > > Key: HDFS-13428 > URL: https://issues.apache.org/jira/browse/HDFS-13428 > Project: Hadoop HDFS > Issue Type: Improvement > Components: federation > Affects Versions: 3.0.1 > Environment: Replace {{LinkedList}} with {{ArrayList}} implementa= tion in the StateStoreFileImpl class.=C2=A0 This is especially advantageous= because we can pre-allocate the internal array before a copy occurs.=C2=A0= {{ArrayList}}=C2=A0is faster for iterations and requires less memory than = {{LinkedList}}. > =C2=A0 > {code:java} > protected List getChildren(String path) { > List ret =3D new LinkedList<>(); > File dir =3D new File(path); > File[] files =3D dir.listFiles(); > if (files !=3D null) { > for (File file : files) { > String filename =3D file.getName(); > ret.add(filename); > } > } > return ret; > }{code} > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Trivial > Attachments: HDFS-13428.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org