From hdfs-issues-return-216343-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Apr 12 06:12:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 80CC918064A for ; Thu, 12 Apr 2018 06:12:05 +0200 (CEST) Received: (qmail 29261 invoked by uid 500); 12 Apr 2018 04:12:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 29246 invoked by uid 99); 12 Apr 2018 04:12:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 04:12:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 080EC1A0049 for ; Thu, 12 Apr 2018 04:12:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id dV_9j_zZFhNQ for ; Thu, 12 Apr 2018 04:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 694AB5F490 for ; Thu, 12 Apr 2018 04:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A493DE05AE for ; Thu, 12 Apr 2018 04:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 560A8240C6 for ; Thu, 12 Apr 2018 04:12:00 +0000 (UTC) Date: Thu, 12 Apr 2018 04:12:00 +0000 (UTC) From: "genericqa (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13388) RequestHedgingProxyProvider calls multiple configured NNs all the time MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13388?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1643= 4908#comment-16434908 ]=20 genericqa commented on HDFS-13388: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s= {color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{co= lor} | {color:red} HDFS-13388 does not apply to trunk. Rebase required? Wro= ng Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {co= lor} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HDFS-13388 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1291866= 6/HADOOP-13388.0009.patch | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23892= /console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > RequestHedgingProxyProvider calls multiple configured NNs all the time > ---------------------------------------------------------------------- > > Key: HDFS-13388 > URL: https://issues.apache.org/jira/browse/HDFS-13388 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client > Reporter: Jinglun > Assignee: Jinglun > Priority: Major > Fix For: 2.10.0, 3.2.0, 3.1.1 > > Attachments: HADOOP-13388.0001.patch, HADOOP-13388.0002.patch, HA= DOOP-13388.0003.patch, HADOOP-13388.0004.patch, HADOOP-13388.0005.patch, HA= DOOP-13388.0006.patch, HADOOP-13388.0007.patch, HADOOP-13388.0008.patch, HA= DOOP-13388.0009.patch > > > In HDFS-7858 RequestHedgingProxyProvider was designed to "first simultane= ously call multiple configured NNs to decide which is the active Namenode a= nd then for subsequent calls it will invoke the previously successful NN ."= But the current code call multiple configured NNs every time even when we = already got the successful NN.=20 > That's because in RetryInvocationHandler.java, ProxyDescriptor's member = proxyInfo is assigned only when it is constructed or when failover occurs. = RequestHedgingProxyProvider.currentUsedProxy is null in both cases, so the = only proxy we can get is always a dynamic proxy handled by RequestHedgingIn= vocationHandler.class.=C2=A0RequestHedgingInvocationHandler.class handles i= nvoked method by calling multiple configured NNs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org