hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "genericqa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13363) Record file path when FSDirAclOp throws AclException
Date Wed, 04 Apr 2018 18:42:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425996#comment-16425996
] 

genericqa commented on HDFS-13363:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 18s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 10s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m 42s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m 25s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m  2s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 49s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m  8s{color}
| {color:green} branch has no errors when building and testing our client artifacts. {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 36s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 16s{color} |
{color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 10s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 43s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 33s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 16m 33s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m  2s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 47s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m  9s{color}
| {color:green} patch has no errors when building and testing our client artifacts. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m  9s{color} | {color:red}
hadoop-hdfs-project/hadoop-hdfs generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 12s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 26s{color} | {color:green}
hadoop-hdfs-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 96m 47s{color} | {color:red}
hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 26s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}200m 42s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
|  |  Redundant nullcheck of iip, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.getAclStatus(FSDirectory,
FSPermissionChecker, String)  Redundant null check at FSDirAclOp.java:is known to be non-null
in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.getAclStatus(FSDirectory, FSPermissionChecker,
String)  Redundant null check at FSDirAclOp.java:[line 202] |
|  |  Redundant nullcheck of iip, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.modifyAclEntries(FSDirectory,
FSPermissionChecker, String, List)  Redundant null check at FSDirAclOp.java:is known to be
non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.modifyAclEntries(FSDirectory,
FSPermissionChecker, String, List)  Redundant null check at FSDirAclOp.java:[line 57] |
|  |  Redundant nullcheck of iip, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.removeAcl(FSDirectory,
FSPermissionChecker, String)  Redundant null check at FSDirAclOp.java:is known to be non-null
in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.removeAcl(FSDirectory, FSPermissionChecker,
String)  Redundant null check at FSDirAclOp.java:[line 142] |
|  |  Redundant nullcheck of iip, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.removeAclEntries(FSDirectory,
FSPermissionChecker, String, List)  Redundant null check at FSDirAclOp.java:is known to be
non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.removeAclEntries(FSDirectory,
FSPermissionChecker, String, List)  Redundant null check at FSDirAclOp.java:[line 88] |
|  |  Redundant nullcheck of iip, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.removeDefaultAcl(FSDirectory,
FSPermissionChecker, String)  Redundant null check at FSDirAclOp.java:is known to be non-null
in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.removeDefaultAcl(FSDirectory, FSPermissionChecker,
String)  Redundant null check at FSDirAclOp.java:[line 118] |
|  |  Redundant nullcheck of iip, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.setAcl(FSDirectory,
FSPermissionChecker, String, List)  Redundant null check at FSDirAclOp.java:is known to be
non-null in org.apache.hadoop.hdfs.server.namenode.FSDirAclOp.setAcl(FSDirectory, FSPermissionChecker,
String, List)  Redundant null check at FSDirAclOp.java:[line 168] |
| Failed junit tests | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure |
|   | hadoop.hdfs.server.namenode.TestReencryptionWithKMS |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b |
| JIRA Issue | HDFS-13363 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12917559/HDFS-13363.001.patch
|
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient
 findbugs  checkstyle  |
| uname | Linux 451eb8da8915 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / b779f4f |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/23777/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
|
| unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23777/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23777/testReport/ |
| Max. process+thread count | 3161 (vs. ulimit of 10000) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
|
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/23777/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Record file path when FSDirAclOp throws AclException
> ----------------------------------------------------
>
>                 Key: HDFS-13363
>                 URL: https://issues.apache.org/jira/browse/HDFS-13363
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: Gabor Bota
>            Priority: Minor
>         Attachments: HDFS-13363.001.patch
>
>
> When AclTransformation methods throws AclException, it does not record the file path
that has the exception. Therefore even if it throws an exception, we would never know which
file has those invalid ACLs.
>  
> These AclTransformation methods are invoked in FSDirAclOp methods, which know the file
path. These FSDirAclOp methods can catch AclException, and then add the file path in the
error message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message