hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "LiXin Ge (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13333) Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is missing
Date Wed, 11 Apr 2018 03:33:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433348#comment-16433348
] 

LiXin Ge commented on HDFS-13333:
---------------------------------

[~elek] Thanks for your review and advice, you suddenly remind me of the compatibility and universality that slip
from my memory when I modifying the interface of {{ServicePlugin}}, agree with you.

For the code logic itself, an appointed exception type will be better. For the Ozone system,
compatibility is a problem but not the unacceptable one in consideration of  the user number
currently we have. As you mentioned, universality that affect all the plugin we will have
in the future is the really problem in my opinion.

In patch 003 I revert the {{HddsDatanodeService#start}} to just throw RuntimeException, but
still retained the specified log for different exception type.

> Ozone: Introduce a new SCM Exception which will be thrown when mandatory property is
missing 
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13333
>                 URL: https://issues.apache.org/jira/browse/HDFS-13333
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: LiXin Ge
>            Priority: Major
>              Labels: newbie
>         Attachments: HDFS-13333-HDFS-7240.001.patch, HDFS-13333-HDFS-7240.002.patch,
HDFS-13333-HDFS-7240.003.patch, HDFS-13333.001.patch
>
>
> It's better to have a separate SCM Exception to indicate a missing mandatory property.
This was proposed by [~xyao] in  [this comment| https://issues.apache.org/jira/browse/HDFS-13300?focusedCommentId=16408553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16408553]




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message