hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Yan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13326) RBF: Improve the interfaces to modify and view mount tables
Date Fri, 06 Apr 2018 22:09:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429077#comment-16429077
] 

Wei Yan commented on HDFS-13326:
--------------------------------

[~gangli2384], some comments on [^HDFS-13326.000.patch].

(1) For add cmd, if mount entry exists, we can directly print out error message and leave
the "update" to the update cmd (following existing RPC implementation).

(2) For update cmd, currently RPC side supports both add and update, so we can just follow.
To be simple, just parsing the input parameters (like what we did in add cmd) and building
a MountTable object, then sending to RPC end.

Some minors:
(1) Change the "namespace" to "nameservice"
(2) Set readonly to false if no input parameter
(3) Remove the line change in TestRouterAdmin.java.
(4) Also need to update hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
(5) Need to fix the checkstyle errors

> RBF: Improve the interfaces to modify and view mount tables
> -----------------------------------------------------------
>
>                 Key: HDFS-13326
>                 URL: https://issues.apache.org/jira/browse/HDFS-13326
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Gang Li
>            Priority: Minor
>         Attachments: HDFS-13326.000.patch
>
>
> 1. From DFSRouterAdmin cmd, currently the update logic is implemented inside add operation,
where it has some limitation (e.g. cannot update "readonly" or removing a destination).  Given
the RPC alreadys separate add and update operations, it would be better to do the same in
cmd level.
> 2. Currently in the MountTable tab, the "readonly" field always show empty, no matter
whether the mount entry is readonly or not. From the code perspective, it tries to show:
> {code:java}
> <td class="dfshealth-node-icon dfshealth-mount-read-only-{readonly}"/>{code}
> The federationhealth.html will load hadoop.css, however the hadoop.css doesn't have
classes with a prefix "dfshealth-mount-read-only". This could be fixed in HDFS-13204.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message