hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12588) Use GenericOptionsParser for scm and ksm daemon
Date Thu, 26 Apr 2018 21:56:08 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455340#comment-16455340

Hudson commented on HDFS-12588:

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14070/])
HDFS-12588. Use GenericOptionsParser for scm and ksm daemon. Contributed (omalley: rev 207523915dde46bc27b7c8320c258876ed050b48)
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/cli/SCMCLI.java
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeySpaceManager.java
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/scm/StorageContainerManager.java

> Use GenericOptionsParser for scm and ksm daemon
> -----------------------------------------------
>                 Key: HDFS-12588
>                 URL: https://issues.apache.org/jira/browse/HDFS-12588
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>             Fix For: HDFS-720
>         Attachments: HDFS-12588-HDFS-7240.001.patch, HDFS-12588-HDFS-7240.002.patch,
HDFS-12588-HDFS-7240.003.patch, HDFS-12588-HDFS-7240.004.patch, HDFS-12588-HDFS-7240.005.patch,
> Most of the hadoop commands use the GenericOptionsParser to use some common CLI arguments
(such as -conf or -D or -libjars to define configuration/modify configuration/modify classpath).
> I suggest to use the same common options to scm and ksm daemons as well, as:
> 1. It allows to use the existing cluster management tools/scripts as the daemons could
be configured in the same way as namenode and datanode
> 2. It follows the convention from the hadoop common.
> 3. It's easier to develop from the IDE (I start the ksm/scm/datanode/namenode from intellij
but I need to add the configuration to the classpath. With -conf I would able to use external
> I found one problem during the implementation. Until now we used `hdfs scm` command both
for the daemon and the scm command line client. If there were no parameters the daemon is
started, with parameters the cli is started. The help listed only the damon.
> The -conf (GenericOptionParser) could be used only if we separate the scm and scmcli
commands. But any way, it's a more clean and visible if we have separated `hdfs scm` and `hdfs

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message