hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-9593) BlockTokenIdentifier Code Review
Date Thu, 19 Apr 2018 22:58:00 GMT

     [ https://issues.apache.org/jira/browse/HDFS-9593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

BELUGA BEHR updated HDFS-9593:
    Status: Patch Available  (was: Open)


 * Use explicit StringBuffer
 * Remove obsolete 'isEquals' method
 * Replace existing 'hashcode' method with Eclipse generated one
 * Small clean ups

> BlockTokenIdentifier Code Review
> --------------------------------
>                 Key: HDFS-9593
>                 URL: https://issues.apache.org/jira/browse/HDFS-9593
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: BlockTokenIdentifier.HDFS-9593.patch, HDFS-9593.2.patch
> Please find attached a code review of BlockTokenIdentifier.
> The only real change is using an explicit StringBuilder instead of an implicit one so
that the internal buffer may be set more appropriately and checking for zero-length string
instead of comparing to an empty string.  The relatively small default buffer of 16 bytes
would need to be expanded several times to fit the incoming string.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message