hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7101) Potential null dereference in DFSck#doWork()
Date Tue, 10 Apr 2018 15:13:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432438#comment-16432438
] 

Akira Ajisaka commented on HDFS-7101:
-------------------------------------

LGTM, +1

> Potential null dereference in DFSck#doWork()
> --------------------------------------------
>
>                 Key: HDFS-7101
>                 URL: https://issues.apache.org/jira/browse/HDFS-7101
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.5.1
>            Reporter: Ted Yu
>            Assignee: skrho
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-7101.v1.patch, HDFS-7101_001.patch
>
>
> {code}
>     String lastLine = null;
>     int errCode = -1;
>     try {
>       while ((line = input.readLine()) != null) {
> ...
>     if (lastLine.endsWith(NamenodeFsck.HEALTHY_STATUS)) {
>       errCode = 0;
> {code}
> If readLine() throws exception, lastLine may be null, leading to NPE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message