From hdfs-issues-return-214669-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Mar 27 18:59:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 37827180671 for ; Tue, 27 Mar 2018 18:59:04 +0200 (CEST) Received: (qmail 40176 invoked by uid 500); 27 Mar 2018 16:59:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 40160 invoked by uid 99); 27 Mar 2018 16:59:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2018 16:59:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8ADACC6BEE for ; Tue, 27 Mar 2018 16:59:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id jO_D6OR0Us9Q for ; Tue, 27 Mar 2018 16:59:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 56BA15F4EB for ; Tue, 27 Mar 2018 16:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8A592E0DFD for ; Tue, 27 Mar 2018 16:59:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 440DC2150B for ; Tue, 27 Mar 2018 16:59:00 +0000 (UTC) Date: Tue, 27 Mar 2018 16:59:00 +0000 (UTC) From: =?utf-8?Q?=C3=8D=C3=B1igo_Goiri_=28JIRA=29?= To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13248) RBF: Namenode need to choose block location for the client MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13248?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1641= 5925#comment-16415925 ]=20 =C3=8D=C3=B1igo Goiri commented on HDFS-13248: ------------------------------------ {quote} One comment for this: I would suggest to move following codes into rbf and = be called in NameNodeRpcServer. {quote} Currently, hadoop-hdfs-rbf depends on hadoop-hdfs, not the other way around= . If we do this, we would have a cyclic dependency. {quote} Does this mean we have tested in real cluster and it will return client ip = address rather than router ip? {quote} Correct. I haven't tested at scale but in our dev deployment. > RBF: Namenode need to choose block location for the client > ---------------------------------------------------------- > > Key: HDFS-13248 > URL: https://issues.apache.org/jira/browse/HDFS-13248 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Weiwei Wu > Assignee: =C3=8D=C3=B1igo Goiri > Priority: Major > Attachments: HDFS-13248.000.patch, HDFS-13248.001.patch, clientMa= chine-call-path.jpeg, debug-info-1.jpeg, debug-info-2.jpeg > > > When execute a put operation via router, the NameNode will choose block l= ocation for the router, not for the real client.=C2=A0This=C2=A0will affect= the file's locality. > I think on both NameNode and Router, we should add a new addBlock method,= or add a parameter for the current addBlock method, to pass the real clien= t information. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org