hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plamen Jeliazkov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-13331) Add lastSeenStateId to RpcRequestHeader.
Date Fri, 30 Mar 2018 20:42:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420913#comment-16420913
] 

Plamen Jeliazkov edited comment on HDFS-13331 at 3/30/18 8:41 PM:
------------------------------------------------------------------

I agree we should try to leverage {{Connection}} objects and that ThreadLocal would be hacky.
I've taken the {{Connection}} approach but I am currently hitting an issue in that DFSClients
re-use {{Connections}}, but with multiple DFSClients having their own {{AlignmentContext}}
then only the first instantiated {{Connection}} will have its {{AlignmentContext}} updated.

I am thinking now that it needs to live in the {{Call}} object instead... I will continue
experimenting however and report next week.

Also, no need to apologize. We are on the same page / team here. :) In fact its probably more
fitting to address this as part of this JIRA then the last anyway as now its easier to focus
on the client side logic.


was (Author: zero45):
I agree we should try to leverage {{Connection}} objects and that ThreadLocal would be hacky.
I've taken the {{Connection}} approach but I am currently hitting an issue in that DFSClients
re-use {{Connection}}s, but with multiple DFSClients having their own {{AlignmentContext}}
then only the first instantiated {{Connection}} will have its {{AlignmentContext}} updated.

I am thinking now that it needs to live in the {{Call}} object instead... I will continue
experimenting however and report next week.

Also, no need to apologize. We are on the same page / team here. :) In fact its probably more
fitting to address this as part of this JIRA then the last anyway as now its easier to focus
on the client side logic.

> Add lastSeenStateId to RpcRequestHeader.
> ----------------------------------------
>
>                 Key: HDFS-13331
>                 URL: https://issues.apache.org/jira/browse/HDFS-13331
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-12943
>            Reporter: Plamen Jeliazkov
>            Assignee: Plamen Jeliazkov
>            Priority: Major
>         Attachments: HDFS-13331-HDFS-12943.002.patch, HDFS-13331-HDFS-12943.003..patch,
HDFS-13331.trunk.001.patch, HDFS_13331.trunk.000.patch
>
>
> HDFS-12977 added a stateId into the RpcResponseHeader which is returned by NameNode and
stored by DFSClient.
> This JIRA is to followup on that work and have the DFSClient send their stored "lastSeenStateId"
in the RpcRequestHeader so that ObserverNodes can then compare with their own and act accordingly.
> This JIRA work focuses on just the part of making DFSClient send their state through
RpcRequestHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message