hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13252) Code refactoring: Remove Diff.ListType
Date Fri, 09 Mar 2018 23:23:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393758#comment-16393758
] 

Tsz Wo Nicholas Sze commented on HDFS-13252:
--------------------------------------------

The test failure does not seem related.  All the checkstyle warnings are LineLength.  I will
just fix them before committing the patch.

> Code refactoring: Remove Diff.ListType
> --------------------------------------
>
>                 Key: HDFS-13252
>                 URL: https://issues.apache.org/jira/browse/HDFS-13252
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: snapshots
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>         Attachments: h13252_20170308.patch, h13252_20170309.patch
>
>
> In Diff, there are only two lists, created and deleted.  It is easier to trace the code
if the methods have the list type in the method name, instead of passing a ListType parameter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message