hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13226) RBF: We should throw the failure validate and refuse this mount entry
Date Thu, 08 Mar 2018 02:43:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390628#comment-16390628

Yiqun Lin commented on HDFS-13226:

{quote}and the end user really want to realize what mistake he has made, and we want to change
the return type from boolean to void.
Makes sense to me. Three comments for the v003 patch.

1.In {{MountTable#validate}}, would you just use throwing exception to replace the log printing
like {{MembershipState#validate}}? I think you have changed some validate logic. 
 2.Please update the javadoc of {{MountTable#validate}}.
 3.Add new test for {{MountTable#validate}}.

> RBF: We should throw the failure validate and refuse this mount entry
> ---------------------------------------------------------------------
>                 Key: HDFS-13226
>                 URL: https://issues.apache.org/jira/browse/HDFS-13226
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>    Affects Versions: 3.2.0
>            Reporter: maobaolong
>            Assignee: maobaolong
>            Priority: Major
>              Labels: RBF
>             Fix For: 3.2.0
>         Attachments: HDFS-13226.001.patch, HDFS-13226.002.patch, HDFS-13226.003.patch,
> one of the mount entry source path rule is that the source path must start with '\',
somebody didn't follow the rule and execute the following command:
> {code:bash}
> $ hdfs dfsrouteradmin -add addnode/ ns1 /addnode/
> {code}
> But, the console show we are successful add this entry.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message