hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11971) libhdfs++: A few portability issues
Date Thu, 22 Mar 2018 21:58:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410467#comment-16410467
] 

Hudson commented on HDFS-11971:
-------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13869 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13869/])
HDFS-11971: libhdfs++: [Fix] a few portability issues.  Contributed by (james.clampffer: rev
c5e7a69523f4bce0f09c7afe423452c36213a072)
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/configuration.h
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/cc/find/CMakeLists.txt
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/c/cat/CMakeLists.txt
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/cc/gendirs/CMakeLists.txt
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/cc/connect_cancel/CMakeLists.txt
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/cc/cat/CMakeLists.txt
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tools/CMakeLists.txt
* (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/examples/c/connect_cancel/CMakeLists.txt


> libhdfs++: A few portability issues
> -----------------------------------
>
>                 Key: HDFS-11971
>                 URL: https://issues.apache.org/jira/browse/HDFS-11971
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Anatoli Shein
>            Assignee: Anatoli Shein
>            Priority: Major
>         Attachments: HDFS-11971.HDFS-8707.000.patch, HDFS-11971.HDFS-8707.001.patch,
HDFS-11971.HDFS-8707.002.patch, HDFS-11971.HDFS-8707.003.patch
>
>
> I recently encountered a few portability issues with libhdfs++ while trying to build
it as a stand alone project (and also as part of another Apache project).
> 1. Method fixCase in configuration.h file produces a warning "conversion to ‘char’
from ‘int’ may alter its value [-Werror=conversion]" which does not allow libhdfs++ to
be compiled as part of the codebase that treats such warnings as errors (can be fixed with
a simple cast).
> 2. In CMakeLists.txt file (in libhdfspp directory) we do find_package(Threads) however
we do not link it to the targets (e.g. hdfspp_static), which causes the build to fail with
pthread errors. After the Threads package is found we need to link it using ${CMAKE_THREAD_LIBS_INIT}.
> 3. All the tools and examples fail to build as part of a standalone libhdfs++ because
they are missing multiple libraries such as protobuf, ssl, pthread, etc. This happens because
we link them to a shared library hdfspp instead of hdfspp_static library. We should either
link all the tools and examples to hdfspp_static library or explicitly add linking to all
missing libraries for each tool/example.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message