hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (HDFS-13188) Disk Balancer: Support multiple block pools during block move
Date Sun, 25 Feb 2018 19:11:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376200#comment-16376200
] 

Íñigo Goiri commented on HDFS-13188:
------------------------------------

The unit test seem to [pass|https://builds.apache.org/job/PreCommit-HDFS-Build/23183/testReport/org.apache.hadoop.hdfs.server.diskbalancer/].
A few minor comments (some already come from the previous code but we could fix here):
* The lines break in {{DiskBalancerTestUtil#getBlockCount}} are weird.
* Space missing in {{if(checkblockPoolCount)}}
* Don't compact {{import org.apache.hadoop.hdfs.*;}}
* We have {{assertTrue(DiskBalancerTestUtil.getBlockCount(volume, true) > 0);}} but we
could go for assertEquals(0, DiskBalancerTestUtil.getBlockCount(volume, true));}}.
* {{TestDiskBalancer}} uses {{Logger}} so you could go for {{LOG.info("{}: Block Count : {}",
refs, DiskBalancerTestUtil.getBlockCount(volume));}}

> Disk Balancer: Support multiple block pools during block move
> -------------------------------------------------------------
>
>                 Key: HDFS-13188
>                 URL: https://issues.apache.org/jira/browse/HDFS-13188
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: diskbalancer
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>         Attachments: HDFS-13188.01.patch, HDFS-13188.02.patch
>
>
> During execute plan:
> *Federated setup:*
> When multiple block pools are there, it will only copy from blocks from first block pool
to destination disk, when balancing.
> We want to distribute the blocks from all block pools on source disk to destination
disk during balancing.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message