hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13110) [SPS]: Reduce the number of APIs in NamenodeProtocol used by external satisfier
Date Thu, 15 Feb 2018 18:28:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366065#comment-16366065
] 

Uma Maheswara Rao G commented on HDFS-13110:
--------------------------------------------

Thanks [~rakeshr] for addressing my comments. I am +1 on latest patch, on addressing checkstyle
warnings reported.

> [SPS]: Reduce the number of APIs in NamenodeProtocol used by external satisfier
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-13110
>                 URL: https://issues.apache.org/jira/browse/HDFS-13110
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>            Priority: Major
>         Attachments: HDFS-13110-HDFS-10285-00.patch, HDFS-13110-HDFS-10285-01.patch,
HDFS-13110-HDFS-10285-02.patch, HDFS-13110-HDFS-10285-03.patch, HDFS-13110-HDFS-10285-04.patch,
HDFS-13110-HDFS-10285-05.patch
>
>
> This task is to address the following [~daryn]'s comments. Please refer HDFS-10285 to
see more detailed discussion.
> *Comment-10)*
> {quote}
> NamenodeProtocolTranslatorPB
> Most of the api changes appear unnecessary.
> IntraSPSNameNodeContext#getFileInfo swallows all IOEs, based on assumption that any and
all IOEs means FNF which probably isn’t the intention during rpc exceptions.
> {quote}
>  *Comment-13)*
> {quote}
> StoragePolicySatisfier
>  It appears to make back-to-back calls to hasLowRedundancyBlocks and getFileInfo for
every file. Haven’t fully groked the code, but if low redundancy is not the common case,
then it shouldn’t be called unless/until needed. It looks like files that are under replicated
are re-queued again?
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message