hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13102) Implement SnapshotSkipList class to store Multi level DirectoryDiffs
Date Tue, 27 Feb 2018 22:39:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379415#comment-16379415
] 

Tsz Wo Nicholas Sze commented on HDFS-13102:
--------------------------------------------

- The ListItr class can be moved as an anonymous class.
{code}
  @Override
  public Iterator<DirectoryDiff> iterator() {
    return new Iterator<DirectoryDiff>() {
      final Iterator<SkipListNode> i = skipNodeList.iterator();

      @Override
      public boolean hasNext() {
        return i.hasNext();
      }

      @Override
      public DirectoryDiff next() {
        return i.next().getDiff();
      }
    };
  }
{code}


> Implement SnapshotSkipList class to store Multi level DirectoryDiffs
> --------------------------------------------------------------------
>
>                 Key: HDFS-13102
>                 URL: https://issues.apache.org/jira/browse/HDFS-13102
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: snapshots
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>         Attachments: HDFS-13102.001.patch, HDFS-13102.002.patch, HDFS-13102.003.patch,
HDFS-13102.004.patch, HDFS-13102.005.patch, HDFS-13102.006.patch, HDFS-13102.007.patch
>
>
> HDFS-11225 explains an issue where deletion of older snapshots can take a very long time
in case the no of snapshot diffs is quite large for directories. For any directory under a
snapshot, to construct the children list , it needs to combine all the diffs from that particular
snapshot to the last snapshotDiff record and reverseApply to the current children list of
the directory on live fs. This can take  a significant time if the no of snapshot diffs are
quite large and changes per diff is significant.
> This Jira proposes to store the Directory diffs in a SnapshotSkip list, where we store
multi level DirectoryDiffs. At each level, the Directory Diff will be cumulative diff of k
snapshot diffs,
> where k is the level of a node in the list. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message