From hdfs-issues-return-208954-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jan 30 09:45:14 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 3839A18061A for ; Tue, 30 Jan 2018 09:45:14 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 28395160C54; Tue, 30 Jan 2018 08:45:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 72CA7160C42 for ; Tue, 30 Jan 2018 09:45:13 +0100 (CET) Received: (qmail 59979 invoked by uid 500); 30 Jan 2018 08:45:12 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 59968 invoked by uid 99); 30 Jan 2018 08:45:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jan 2018 08:45:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F26B81A3B42 for ; Tue, 30 Jan 2018 08:45:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id P0WZH4sg60C0 for ; Tue, 30 Jan 2018 08:45:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5ABAC60EC8 for ; Tue, 30 Jan 2018 08:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 917E0E0115 for ; Tue, 30 Jan 2018 08:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5626D240EE for ; Tue, 30 Jan 2018 08:45:00 +0000 (UTC) Date: Tue, 30 Jan 2018 08:45:00 +0000 (UTC) From: "Yiqun Lin (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-13043) RBF: Expose the state of the Routers in the federation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-13043?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1634= 4691#comment-16344691 ]=20 Yiqun Lin commented on HDFS-13043: ---------------------------------- Hi [~elgoiri], agree on your comments. There seems still some places we nee= d to update: Please attach the clean patch, there was one redundant file added in patch. *federationhealth.html* line263:. Would you update the name to a more readable name like {{Members= hip(last update)}}? line264:. Would you update the name to a more readable name like {{Mount t= able(last update)}}? line276: This should be simplified as \{lastMountTableUpdate}. *TestMetricsBase.java* line142 and 152: Can you use {{Time.now}} to set the field=C2=A0{{membersh= ipVersion}} or {{mountTableVersion}} like following? {code:java} router1.setStateStoreVersion(StateStoreVersion.newInstance(Time.now() -2000= , Time.now() -1000)); {code} The json string got in test will look more real and accurate. In addition, can you attach the new screenshot again base on the latest pat= ch? > RBF: Expose the state of the Routers in the federation > ------------------------------------------------------ > > Key: HDFS-13043 > URL: https://issues.apache.org/jira/browse/HDFS-13043 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: =C3=8D=C3=B1igo Goiri > Assignee: =C3=8D=C3=B1igo Goiri > Priority: Major > Attachments: HDFS-13043.000.patch, HDFS-13043.001.patch, HDFS-130= 43.002.patch, HDFS-13043.003.patch, HDFS-13043.004.patch, HDFS-13043.005.pa= tch, router-info.png > > > The Router should expose the state of the other Routers in the federation= through a user UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org