From hdfs-issues-return-207304-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Jan 8 18:27:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 611D1180607 for ; Mon, 8 Jan 2018 18:27:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4F92D160C3E; Mon, 8 Jan 2018 17:27:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 923B5160C1E for ; Mon, 8 Jan 2018 18:27:04 +0100 (CET) Received: (qmail 63094 invoked by uid 500); 8 Jan 2018 17:27:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 63082 invoked by uid 99); 8 Jan 2018 17:27:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 17:27:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 13B39C1AC3 for ; Mon, 8 Jan 2018 17:27:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JIfA99HPT43O for ; Mon, 8 Jan 2018 17:27:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5ABEC5F22E for ; Mon, 8 Jan 2018 17:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DC050E09A5 for ; Mon, 8 Jan 2018 17:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 93CF5212F7 for ; Mon, 8 Jan 2018 17:27:00 +0000 (UTC) Date: Mon, 8 Jan 2018 17:27:00 +0000 (UTC) From: "Robert Joseph Evans (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-12984) BlockPoolSlice can leak in a mini dfs cluster MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316626#comment-16316626 ] Robert Joseph Evans commented on HDFS-12984: -------------------------------------------- [~ajayydv], I also ran into issues trying to reproduce this in some environments. Specifically I could never make it happen on my MBP and I don't know why. But if you look at the code inside the BlockPoolSlice https://github.com/apache/hadoop/blob/01f3f2167ec20b52a18bc2cf250fb4229cfd2c14/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java#L165-L173 If an instance of this is ever created it can never be collected. I am not sure why BlockPoolSlice instances are created some times by a MiniDFSCluster and not others. I am not that familiar with the internals of the DataNode to say off the top of my head. Glad to see you going in the right direction, and I agree that removing everything from the ShutdownHooksManager is far from ideal, but I didn't see this happening, at least not with 2.7.5 and 2.6.2. > BlockPoolSlice can leak in a mini dfs cluster > --------------------------------------------- > > Key: HDFS-12984 > URL: https://issues.apache.org/jira/browse/HDFS-12984 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.7.5 > Reporter: Robert Joseph Evans > Assignee: Ajay Kumar > Attachments: Screen Shot 2018-01-05 at 4.38.06 PM.png, Screen Shot 2018-01-05 at 5.26.54 PM.png, Screen Shot 2018-01-05 at 5.31.52 PM.png > > > When running some unit tests for storm we found that we would occasionally get out of memory errors on the HDFS integration tests. > When I got a heap dump I found that the ShutdownHookManager was full of BlockPoolSlice$1 instances. Which hold a reference to the BlockPoolSlice which then in turn holds a reference to the DataNode etc.... > It looks like when shutdown is called on the BlockPoolSlice there is no way to remove the shut down hook in because no reference to it is saved. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org