From hdfs-issues-return-207303-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Jan 8 18:12:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id F04D6180607 for ; Mon, 8 Jan 2018 18:12:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DF99F160C2C; Mon, 8 Jan 2018 17:12:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2FB33160C1E for ; Mon, 8 Jan 2018 18:12:06 +0100 (CET) Received: (qmail 18961 invoked by uid 500); 8 Jan 2018 17:12:05 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 18948 invoked by uid 99); 8 Jan 2018 17:12:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 17:12:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C92DF1A020D for ; Mon, 8 Jan 2018 17:12:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id msnWnSn5IClq for ; Mon, 8 Jan 2018 17:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A2B2B5F3DF for ; Mon, 8 Jan 2018 17:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D59CAE09A5 for ; Mon, 8 Jan 2018 17:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9731F240EE for ; Mon, 8 Jan 2018 17:12:00 +0000 (UTC) Date: Mon, 8 Jan 2018 17:12:00 +0000 (UTC) From: =?utf-8?Q?=C3=8D=C3=B1igo_Goiri_=28JIRA=29?= To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HDFS-12934) RBF: Federation supports global quota MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-12934?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1631= 6598#comment-16316598 ]=20 =C3=8D=C3=B1igo Goiri edited comment on HDFS-12934 at 1/8/18 5:11 PM: ------------------------------------------------------------ Thanks [~linyiqun], I think this is pretty much good to go. A few minor comments on [^HDFS-12934.006.patch]: * Check styles in the test can be solved. * In {{Router}}, we could get rid of the field for {{isQuotaEnabled}} (keep= it as var) and use {{this.quotaManager =3D=3D null}} in {{isQuotaEnabled()= }}. * {{Router#getQuotaManager()}} should just return {{this.quotaManager}}; no= need on doing the {{isQuotaEnabled()}}. * For the comment about {{DirectoryWithQuotaFeature}}, I was talking about = linking to this class method in the javadoc of {{RouterQuotaUsage#verifyNam= espaceQuota}}. * No need for {{timeOutMs}} in the internal {{getQuotaUsage()}}, just call = it {{getQuotaUsageInternal()}} or something (not sure it can be made protec= ted). It'd be also good if we could move this into the module approach (mor= e on this at the end of this comment). For the relation with HDFS-12919, I agree that the method returning is too = convoluted and no need to carry it over; we cna leave it for that JIRA. However, in the latets patches, I made the erasure coding in {{RouterRpcSer= ver}} to be a module. I think we should do this here too, it only requires changing the visibilit= y of a couple methods in {{RouterRpcServer}} and starts what I think is the= right direction. BTW, review appreciated on HDFS-12919 (I'm relying on Jenkins for tests bec= ause I'm having issues for testing EC policies on Windows from 3.0). was (Author: elgoiri): Thanks [~linyiqun], I think this is pretty much good to go. A few minor comments on [^HDFS-12934.006.patch]: * Check styles in the test can be solved. * In {{Router}}, we could get rid of the field for {{isQuotaEnabled}} (keep= it as var) and use {{this.quotaManager =3D=3D null}} in {{isQuotaEnabled()= }}. * {{Router#getQuotaManager()}} should just return {{this.quotaManager}}; no= need on doing the {{isQuotaEnabled()}}. * For the comment about {{DirectoryWithQuotaFeature}}, I was talking about = linking to this class method in the javadoc of {{RouterQuotaUsage#verifyNam= espaceQuota}}. For the relation with HDFS-12919, I agree that the method returning is too = convoluted and no need to carry it over; we cna leave it for that JIRA. However, in the latets patches, I made the erasure coding in {{RouterRpcSer= ver}} to be a module. I think we should do this here too, it only requires changing the visibilit= y of a couple methods in {{RouterRpcServer}} and starts what I think is the= right direction. BTW, review appreciated on HDFS-12919 (I'm relying on Jenkins for tests bec= ause I'm having issues for testing EC policies on Windows from 3.0). > RBF: Federation supports global quota > ------------------------------------- > > Key: HDFS-12934 > URL: https://issues.apache.org/jira/browse/HDFS-12934 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: 3.0.0 > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Labels: RBF > Attachments: HDFS-12934.001.patch, HDFS-12934.002.patch, HDFS-129= 34.003.patch, HDFS-12934.004.patch, HDFS-12934.005.patch, HDFS-12934.006.pa= tch, RBF support global quota.pdf > > > Now federation doesn't support set the global quota for each folder. Curr= ently the quota will be applied for each subcluster under the specified fol= der via RPC call. > It will be very useful for users that federation can support setting glob= al quota and exposing the command of this. > In a federated environment, a folder can be spread across multiple subclu= sters. For this reason, we plan to solve this by following way: > # Set global quota across each subcluster. We don't allow each subcluster= can exceed maximun quota value. > # We need to construct one cache map for storing the s= um quota usage of these subclusters under federation folder. Every time we= want to do WRITE operation under specified folder, we will get its quota u= sage from cache and verify its quota. If quota exceeded, throw exception, o= therwise update its quota usage in cache when finishing operations. > The quota will be set to mount table and as a new field in mount table. T= he set/unset command will be like: > {noformat} > hdfs dfsrouteradmin -setQuota -ns -ss > hdfs dfsrouteradmin -clrQuota > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org