From hdfs-issues-return-207148-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Jan 5 09:29:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 7A49E18077B for ; Fri, 5 Jan 2018 09:29:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6A06C160C3B; Fri, 5 Jan 2018 08:29:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AE162160C19 for ; Fri, 5 Jan 2018 09:29:05 +0100 (CET) Received: (qmail 86941 invoked by uid 500); 5 Jan 2018 08:29:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 86393 invoked by uid 99); 5 Jan 2018 08:29:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 08:29:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 870101A0527 for ; Fri, 5 Jan 2018 08:29:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.011 X-Spam-Level: X-Spam-Status: No, score=-100.011 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LFUKLNYkZa-J for ; Fri, 5 Jan 2018 08:29:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 70B215F1BA for ; Fri, 5 Jan 2018 08:29:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 52A66E2582 for ; Fri, 5 Jan 2018 08:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 70D612410E for ; Fri, 5 Jan 2018 08:29:00 +0000 (UTC) Date: Fri, 5 Jan 2018 08:29:00 +0000 (UTC) From: "Doris Gu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312702#comment-16312702 ] Doris Gu commented on HDFS-11806: --------------------------------- Notice journalnode does not parse general options so far, make {{printGenericCommandUsage}} to {{false}} in patch 002, the modification is like this: *Before* {quote}[root@localhost ~]# hdfs journalnode -h 2018-01-05 08:03:32,384 INFO server.JournalNode: STARTUP_MSG: /************************************************************ STARTUP_MSG: Starting JournalNode STARTUP_MSG: host = localhost/172.17.0.19 STARTUP_MSG: args = [-h] STARTUP_MSG: version = 3.1.0-SNAPSHOT ...{quote} *After* {quote}[root@localhost ~]# hdfs journalnode -h Usage: hdfs journalnode JournalNode is a necessary role in a typical HA cluster with QJM. It allows a NameNode to read and write edit logs stored on it's local disk. Note that you should run an odd number of JNs, (i.e. 3, 5, 7, etc.), since edit log modifications must be written to a majority of JNs. [root@localhost ~]# {quote} [~sureshms] [~bharatviswa], could you please review this issue for me? Thanks very much! Tips: Due to [https://issues.apache.org/jira/browse/HADOOP-14818], need to test '-h' when there's no active journalnode daemon already, or you'll got {{journalnode is running as process ...}} error. > hdfs journalnode command should support meaningful --help > --------------------------------------------------------- > > Key: HDFS-11806 > URL: https://issues.apache.org/jira/browse/HDFS-11806 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.8.0, 3.0.0-alpha2, 3.1.0 > Reporter: Doris Gu > Attachments: HDFS-11806.001.patch, HDFS-11806.002.patch > > > Most (sub) commands support -help or -h options for detailed help while hdfs journalnode does not. What's worse, when you use "hdfs journalnode -h" to get some help, journalnode daemon starts straightly. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org