hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elek, Marton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-13080) Ozone: Make finalhash in ContainerInfo of StorageContainerDatanodeProtocol.proto optional
Date Tue, 30 Jan 2018 07:58:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-13080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344644#comment-16344644
] 

Elek, Marton commented on HDFS-13080:
-------------------------------------

Fix me If I am wrong, but I think even with the optional flagĀ an NPE could occur as null
shouldn't be set to the protobuf field.

I propose to fix theĀ ContainerManagerImpl.java as well.

I have a local patch for that, I am uploading it to here, to explain what I think, but feel
free to ignore if you don't agree.

> Ozone: Make finalhash in ContainerInfo of StorageContainerDatanodeProtocol.proto optional
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-13080
>                 URL: https://issues.apache.org/jira/browse/HDFS-13080
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>            Priority: Major
>         Attachments: HDFS-13080-HDFS-7240.000.patch, HDFS-13080-HDFS-7240.001.patch
>
>
> ContainerInfo in StorageContainerDatanodeProtocol.proto has a required field, {{finalhash}}
which will be null for an open container, this has to be made as an optional field.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message