hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rushabh S Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12574) Add CryptoInputStream to WebHdfsFileSystem read call.
Date Wed, 17 Jan 2018 22:29:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329613#comment-16329613

Rushabh S Shah commented on HDFS-12574:

Thanks [~daryn] for the review.
Only substantive comment is I think you can revert the changes in NamenodeWebHdfsMethods#redirectURI.
 Instead of passing in a ResponseBuilder and FileStatus just for the sole purpose of letting
OPEN set a header, push the logic up into the open call.  That will also avoid introducing
a new unnecessary getFileInfo for creates.
In the coming patches for supporting EZ for webhdfs create, append, I will use the {{ResponseBuilder}}
in {{redirectUri}}.
I have made the changes for doing getFileInfo just for {{Open, Append, GETFILECHECKSUM}}.

Very trivial comment is instead of donotFollowRedirect, perhaps use followRedirects to match
the name of the HttpURLConnection method name.  It's a bit clumsy to read logic that negates
a negative.
Changed in the latest patch.

> Add CryptoInputStream to WebHdfsFileSystem read call.
> -----------------------------------------------------
>                 Key: HDFS-12574
>                 URL: https://issues.apache.org/jira/browse/HDFS-12574
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption, kms, webhdfs
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>            Priority: Major
>         Attachments: HDFS-12574.001.patch, HDFS-12574.002.patch, HDFS-12574.003.patch,
HDFS-12574.004.patch, HDFS-12574.005.patch, HDFS-12574.006.patch, HDFS-12574.007.patch, HDFS-12574.008.patch,
HDFS-12574.009.patch, HDFS-12574.010.patch

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org

View raw message