hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nanda kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12522) Ozone: Remove the Priority Queues used in the Container State Manager
Date Wed, 24 Jan 2018 19:42:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338119#comment-16338119
] 

Nanda kumar commented on HDFS-12522:
------------------------------------

Thanks [~anu] for updating the patch. Looks pretty good to me.

ContainerStateMap.java Line:86 Extra “;”
{quote}That does not work. Since we don't know what values of info is being updated. If
we want allocatedBytes to be corect, then it is has to updated at a level higher than this.
{quote}
{quote}Technically yes, but unfortunately, we use this to update all fields of the ContainerInfo.
That is when state change is executed, the user can change other fields too.
{quote}
{{ContainerStateMap#updateState}} : As the name suggests, we should use it only for updating
the state of the container. In that case, we can only update the state field and retain all
the other values and also we can work just with containerID as the argument.
{quote}Line numbers are not correct?
{quote}
-443 - 444 This can be removed.- The line numbers were 427 - 429 (It is fixed in patch v2)

 

> Ozone: Remove the Priority Queues used in the Container State Manager
> ---------------------------------------------------------------------
>
>                 Key: HDFS-12522
>                 URL: https://issues.apache.org/jira/browse/HDFS-12522
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Major
>         Attachments: HDFS-12522-HDFS-7240.001.patch, HDFS-12522-HDFS-7240.002.patch
>
>
> During code review of HDFS-12387, it was suggested that we remove the priority queues
that was used in ContainerStateManager. This JIRA tracks that issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message