hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doris Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help
Date Fri, 05 Jan 2018 08:29:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312702#comment-16312702
] 

Doris Gu commented on HDFS-11806:
---------------------------------

Notice journalnode does not  parse general options so far, make {{printGenericCommandUsage}}
to {{false}} in patch 002, the modification is like this:
*Before*
{quote}[root@localhost ~]# hdfs journalnode -h
2018-01-05 08:03:32,384 INFO server.JournalNode: STARTUP_MSG: 
/************************************************************
STARTUP_MSG: Starting JournalNode
STARTUP_MSG:   host = localhost/172.17.0.19
STARTUP_MSG:   args = [-h]
STARTUP_MSG:   version = 3.1.0-SNAPSHOT
...{quote}

*After*
{quote}[root@localhost ~]# hdfs journalnode -h
Usage: hdfs journalnode 
	JournalNode is a necessary role in a typical HA cluster with QJM. It allows a NameNode to
read and write edit logs stored on it's local disk. Note that you should run an odd number
of JNs, (i.e. 3, 5, 7, etc.), since edit log modifications must be written to a majority of
JNs.

[root@localhost ~]# {quote}

[~sureshms] [~bharatviswa], could you please review this issue for me? Thanks very much!
Tips: Due to [https://issues.apache.org/jira/browse/HADOOP-14818], need to test '-h' when
there's no active journalnode daemon already, or you'll got {{journalnode is running as process
...}} error.

> hdfs journalnode command should support meaningful --help
> ---------------------------------------------------------
>
>                 Key: HDFS-11806
>                 URL: https://issues.apache.org/jira/browse/HDFS-11806
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.8.0, 3.0.0-alpha2, 3.1.0
>            Reporter: Doris Gu
>         Attachments: HDFS-11806.001.patch, HDFS-11806.002.patch
>
>
> Most (sub) commands support -help or -h options for detailed help while hdfs journalnode
does not. What's worse, when you use "hdfs journalnode -h" to get some help, journalnode daemon
starts straightly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message