Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 29 Dec 2017 20:04:02 +0000 (UTC)
From: "Lei (Eddy) Xu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.13124210.1513025386000.547841.1514577842484@Atlassian.JIRA>
In-Reply-To: <JIRA.13124210.1513025386000@Atlassian.JIRA>
References: <JIRA.13124210.1513025386000@Atlassian.JIRA> <JIRA.13124210.1513025386644@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HDFS-12915) Fix findbugs warning in
 INodeFile$HeaderFormat.getBlockLayoutRedundancy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 29 Dec 2017 20:04:08 -0000


    [ https://issues.apache.org/jira/browse/HDFS-12915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306500#comment-16306500 ] 

Lei (Eddy) Xu commented on HDFS-12915:
--------------------------------------

[~chris.douglas] Thanks for the patch! +1 on the last patch. 

The {{blockType}} is widely used in HDFS to differentiate a file is EC or not today. I think it should not block this patch in. 

I will commit the latest patch soon.  Thanks for taking care of this, [~chris.douglas] and thanks for the reviews, [~Sammi]

> Fix findbugs warning in INodeFile$HeaderFormat.getBlockLayoutRedundancy
> -----------------------------------------------------------------------
>
>                 Key: HDFS-12915
>                 URL: https://issues.apache.org/jira/browse/HDFS-12915
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Wei-Chiu Chuang
>         Attachments: HDFS-12915.00.patch, HDFS-12915.01.patch, HDFS-12915.02.patch
>
>
> It seems HDFS-12840 creates a new findbugs warning.
> Possible null pointer dereference of replication in org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(BlockType, Short, Byte)
> Bug type NP_NULL_ON_SOME_PATH (click for details) 
> In class org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat
> In method org.apache.hadoop.hdfs.server.namenode.INodeFile$HeaderFormat.getBlockLayoutRedundancy(BlockType, Short, Byte)
> Value loaded from replication
> Dereferenced at INodeFile.java:[line 210]
> Known null at INodeFile.java:[line 207]
> From a quick look at the patch, it seems bogus though. [~eddyxu][~Sammi] would you please double check?


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org