hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chen Liang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12899) Ozone: SCM: BlockManagerImpl close is called twice during StorageContainerManager#stop
Date Wed, 06 Dec 2017 20:16:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280836#comment-16280836
] 

Chen Liang commented on HDFS-12899:
-----------------------------------

Thanks [~nandakumar131] for the catch! the patch LGTM, pending jenkins.

> Ozone: SCM: BlockManagerImpl close is called twice during StorageContainerManager#stop
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-12899
>                 URL: https://issues.apache.org/jira/browse/HDFS-12899
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>         Attachments: HDFS-12899-HDFS-7240.000.patch
>
>
> As part of {{StorageContainerManager#stop}}, we are calling {{scmBlockManager#stop}}
which will internally do {{BlockManagerImpl#close}} and again explicitly we are calling {{scmBlockManager#close}}
using {{IOUtils.cleanupWithLogger(LOG, scmBlockManager)}}. This causes {{RocksDBStore#close}}
to be called twice which inturn does {{MBeans#unregister}} twice, resulting in the following
exception trace (WARN) during the second call
> {noformat}
> 2017-12-06 22:30:06,316 [main] WARN  util.MBeans (MBeans.java:unregister(137)) - Error
unregistering Hadoop:service=Ozone,name=RocksDbStore,dbName=block.db
> javax.management.InstanceNotFoundException: Hadoop:service=Ozone,name=RocksDbStore,dbName=block.db
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1095)
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.exclusiveUnregisterMBean(DefaultMBeanServerInterceptor.java:427)
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.unregisterMBean(DefaultMBeanServerInterceptor.java:415)
> 	at com.sun.jmx.mbeanserver.JmxMBeanServer.unregisterMBean(JmxMBeanServer.java:546)
> 	at org.apache.hadoop.metrics2.util.MBeans.unregister(MBeans.java:135)
> 	at org.apache.hadoop.utils.RocksDBStore.close(RocksDBStore.java:368)
> 	at org.apache.hadoop.ozone.scm.block.BlockManagerImpl.close(BlockManagerImpl.java:506)
> 	at org.apache.hadoop.io.IOUtils.cleanupWithLogger(IOUtils.java:278)
> 	at org.apache.hadoop.ozone.scm.StorageContainerManager.stop(StorageContainerManager.java:900)
> --------stacktrace truncated----------
> 2017-12-06 22:30:06,317 [main] WARN  util.MBeans (MBeans.java:unregister(137)) - Error
unregistering Hadoop:service=Ozone,name=RocksDbStore,dbName=deletedBlock.db
> javax.management.InstanceNotFoundException: Hadoop:service=Ozone,name=RocksDbStore,dbName=deletedBlock.db
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(DefaultMBeanServerInterceptor.java:1095)
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.exclusiveUnregisterMBean(DefaultMBeanServerInterceptor.java:427)
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.unregisterMBean(DefaultMBeanServerInterceptor.java:415)
> 	at com.sun.jmx.mbeanserver.JmxMBeanServer.unregisterMBean(JmxMBeanServer.java:546)
> 	at org.apache.hadoop.metrics2.util.MBeans.unregister(MBeans.java:135)
> 	at org.apache.hadoop.utils.RocksDBStore.close(RocksDBStore.java:368)
> 	at org.apache.hadoop.ozone.scm.block.DeletedBlockLogImpl.close(DeletedBlockLogImpl.java:326)
> 	at org.apache.hadoop.ozone.scm.block.BlockManagerImpl.close(BlockManagerImpl.java:509)
> 	at org.apache.hadoop.io.IOUtils.cleanupWithLogger(IOUtils.java:278)
> 	at org.apache.hadoop.ozone.scm.StorageContainerManager.stop(StorageContainerManager.java:900)
> --------stacktrace truncated----------
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message