hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yiqun Lin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-12875) RBF: Complete logic for -readonly option of dfsrouteradmin add command
Date Thu, 07 Dec 2017 02:55:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281247#comment-16281247
] 

Yiqun Lin edited comment on HDFS-12875 at 12/7/17 2:54 AM:
-----------------------------------------------------------

Thanks for taking over this, [~elgoiri]. The updated patch looks good to me.
Two comment: 
1. Besides unit tests needed to be added in next patch, you may also update related documantation
(HDFSCommands.md, HDFSRouterFederation.md). Also can you remove -order option in {{RouterAdmin#printUsage}}?
From my understanding on this, -order option is not completely implemented in trunk. Correct
me if I am wrong.
2. Seems {{RouterRpcServer#getLocationForPath}} also needs to do read-only check. {{getLocationForPath}}
is used in concat call while this is a WRITE Operation.


was (Author: linyiqun):
Thanks for taking over this, [~elgoiri]. The updated patch looks good to me.
One comment: Besides unit tests needed to be added in next patch, you may also update related
documantation (HDFSCommands.md, HDFSRouterFederation.md). Also can you remove -order option
in {{RouterAdmin#printUsage}}? From my understanding on this, -order option is not completely
implemented in trunk. Correct me if I am wrong. Thanks.

> RBF: Complete logic for -readonly option of dfsrouteradmin add command
> ----------------------------------------------------------------------
>
>                 Key: HDFS-12875
>                 URL: https://issues.apache.org/jira/browse/HDFS-12875
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Yiqun Lin
>            Assignee: Íñigo Goiri
>              Labels: RBF
>         Attachments: HDFS-12875.001.patch, HDFS-12875.002.patch
>
>
> Currently the option -readonly of command {{dfsrouteradmin -add}} doesn't make any sense.The
desired behavior is that read-only mount table that be set in add command cannot be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message