hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nanda kumar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-12751) Ozone: SCM: update container allocated size to container db for all the open containers in ContainerStateManager#close
Date Thu, 21 Dec 2017 09:27:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299750#comment-16299750
] 

Nanda kumar commented on HDFS-12751:
------------------------------------

Chen, you're right. SCM doesn't rely on {{ContainerInfo}} instance from the client, and whatever
change made by the client will not be taken by SCM. The idea or suggestion is to make {{ContainerInfo}}
so robust that the client cannot modify the values, so the client can fully rely on the data
present in {{ContainerInfo}}. There is nothing wrong with the current code, just that there
is a possible loophole using which any client can modify allocated bytes in an instance of
{{ContainerInfo}} returned by SCM. It will no way affect SCM's consistency.

> Ozone: SCM: update container allocated size to container db for all the open containers
in ContainerStateManager#close
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12751
>                 URL: https://issues.apache.org/jira/browse/HDFS-12751
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nanda kumar
>            Assignee: Chen Liang
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12751-HDFS-7240.001.patch, HDFS-12751-HDFS-7240.002.patch
>
>
> Container allocated size is maintained in memory by {{ContainerStateManager}}, this has
to be updated in container db when we shutdown SCM. {{ContainerStateManager#close}} will be
called during SCM shutdown, so updating allocated size for all the open containers should
be done here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org


Mime
View raw message